Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(param-value-converter-registry): wider date converters input type and throw exception #287

Merged
merged 2 commits into from
Jan 30, 2025

refactor(param-value-converter-registry): wider date converters input…

9ebb364
Select commit
Loading
Failed to load commit list.
Merged

refactor(param-value-converter-registry): wider date converters input type and throw exception #287

refactor(param-value-converter-registry): wider date converters input…
9ebb364
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 30, 2025 in 0s

94.65% (-0.33%) compared to a4d85be

View this Pull Request on Codecov

94.65% (-0.33%) compared to a4d85be

Details

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.65%. Comparing base (a4d85be) to head (9ebb364).

Files with missing lines Patch % Lines
src/Param/ParamValueConverterRegistry.php 86.36% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   94.97%   94.65%   -0.33%     
==========================================
  Files          40       40              
  Lines         737      749      +12     
==========================================
+ Hits          700      709       +9     
- Misses         37       40       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.