update tests

make methods public simplify a calculation
silvershop · Mar 4, 2019 · 3417265 · 3417265
1 parent 1b19ffc
commit 3417265
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/Extensions/Constraints/GroupDiscountConstraint.php b/src/Extensions/Constraints/GroupDiscountConstraint.php
@@ -31,7 +31,7 @@ public function filter(DataList $list)
     {
         $groupids = [0];
         if ($member = $this->getMember()) {
-            $groupids = $groupids + $member->Groups()
+            $groupids += $member->Groups()
                 ->map('ID', 'ID')
                 ->toArray();
         }

diff --git a/tests/CalculatorTest.php b/tests/CalculatorTest.php
@@ -117,7 +117,7 @@ public function testZeroOrderDiscount()
         $this->markTestIncomplete('Add assertions');
     }
 
-    function testItemLevelPercentAndAmountDiscounts()
+    public function testItemLevelPercentAndAmountDiscounts()
     {
         OrderDiscount::get()->removeAll();
         OrderDiscount::create(
@@ -171,7 +171,7 @@ function testItemLevelPercentAndAmountDiscounts()
         );
     }
 
-    function testCouponAndDiscountItemLevel()
+    public function testCouponAndDiscountItemLevel()
     {
         OrderDiscount::create(
             [
@@ -208,7 +208,7 @@ function testCouponAndDiscountItemLevel()
         //the order subtotal
     }
 
-    function testItemAndCartLevelAmountDiscounts()
+    public function testItemAndCartLevelAmountDiscounts()
     {
         OrderDiscount::create(
             [
@@ -236,7 +236,7 @@ function testItemAndCartLevelAmountDiscounts()
         $this->markTestIncomplete('test distribution of amounts');
     }
 
-    function testCartLevelAmount()
+    public function testCartLevelAmount()
     {
         //entire cart
         $discount = OrderDiscount::create(
@@ -258,7 +258,7 @@ function testCartLevelAmount()
         $this->assertEquals(25, $calculator->calculate());
     }
 
-    function testCartLevelPercent()
+    public function testCartLevelPercent()
     {
         $discount = OrderDiscount::create(
             [
@@ -284,7 +284,7 @@ function testCartLevelPercent()
         $this->assertEquals(205, $calculator->calculate());
     }
 
-    function testMaxAmount()
+    public function testMaxAmount()
     {
         //percent item discounts
         $discount = OrderDiscount::create(

diff --git a/tests/DiscountReportTest.php b/tests/DiscountReportTest.php
@@ -12,7 +12,7 @@ class DiscountReportTest extends SapphireTest
 
     protected static $fixture_file = 'Discounts.yml';
 
-    function testDiscountReport()
+    public function testDiscountReport()
     {
         $discount = $this->objFromFixture(OrderDiscount::class, 'used');
         $report = new DiscountReport();