Allow modtime zero value

[ghostsquad]

This prevents the vfsdata.go file from changing if the only
thing that has changed is the file modtime.

Resolves #26

[dmitshur]

Sorry about the delay.

Thank you for the PR, but I prefer not to merge this. I think this functionality can and should be achieved orthogonally—it doesn't need to be built into vfsgen.

More specifically, it can be achieved by creating a passthrough http.FileSystem wrapper implementation, one that makes no changes to the input filesystem, except it strips all modtimes to be zero:

// ZeroModTimeFileSystem is an http.FileSystem wrapper.
// It exposes a filesystem exactly like Source, except
// all file modification times are changed to zero.
type ZeroModTimeFileSystem struct {
	Source http.FileSystem
}

func (fs ZeroModTimeFileSystem) Open(name string) (http.File, error) {
	f, err := fs.Source.Open(name)
	return file{f}, err
}

type file struct {
	http.File
}

func (f file) Stat() (os.FileInfo, error) {
	fi, err := f.File.Stat()
	return fileInfo{fi}, err
}

type fileInfo struct {
	os.FileInfo
}

func (fi fileInfo) ModTime() time.Time { return time.Time{} }

[ghostsquad]

This is what I did, but I thought it would be a useful feature if that's the _only_ change you need.

…

On Thu, Jan 4, 2018 at 2:22 PM Dmitri Shuralyov ***@***.***> wrote: Sorry about the delay. Thank you for the PR, but I prefer not to merge this. I think this functionality can and should be achieved orthogonally—it doesn't need to be built into vfsgen. More specifically, it can be achieved by creating a passthrough http.FileSystem wrapper implementation, one that makes no changes to the input filesystem, except it strips all modtimes to be zero: // ZeroModTimeFileSystem is an http.FileSystem wrapper.// It exposes a filesystem exactly like Source, except// all file modification times are changed to zero.type ZeroModTimeFileSystem struct { Source http.FileSystem } func (fs ZeroModTimeFileSystem) Open(name string) (http.File, error) { f, err := fs.Source.Open(name) return file{f}, err } type file struct { http.File } func (f file) Stat() (os.FileInfo, error) { fi, err := f.File.Stat() return fileInfo{fi}, err } type fileInfo struct { os.FileInfo } func (fi fileInfo) ModTime() time.Time { return time.Time{} } — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#40 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3JQF7iNDfWzg2wyiw8h_eApWBglC4hks5tHU9BgaJpZM4RMEAW> .