Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unshift #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ronen-albagli
Copy link

Pull Request Description

Description:
This pull request introduces the UnShift function to the project. The UnShift function allows for shifting a time back by a specified duration, complementing the existing Shift function.

Changes Made:

  • Implemented the UnShift function in the github.com/senseyeio/duration package.
  • Updated documentation to include information about the new UnShift function.
  • Added tests to ensure the correctness of the UnShift function.

Testing Done:
I have tested this code locally by creating test cases to cover various scenarios, including edge cases.

Checklist:

  • I have tested this code locally.
  • I have reviewed the code changes.
  • I have followed the project's coding style guidelines.
  • I have updated the documentation.
  • All tests passed.

Additional Comments:
The UnShift function provides a valuable addition to the existing functionality, enhancing the flexibility of the library.

Reviewers:
@rossmcf @SimonWaldherr @dareid

@ronen-albagli ronen-albagli mentioned this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant