Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[liveramp] Hotfix: Imports hashing functions with the same syntax as other imports #2700

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

nick-Ag
Copy link
Member

@nick-Ag nick-Ag commented Jan 21, 2025

This PR changes the hashing function import to follow the conventions of other actions-core imports.
The existing import causes this build error when running a deploy: https://github.com/segmentio/action-destinations/actions/runs/12894780920/job/35954227746

Testing

Testing not required as this fix can only be tested in GitHub actions
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.46%. Comparing base (ba59ef1) to head (d639ebb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2700   +/-   ##
=======================================
  Coverage   78.46%   78.46%           
=======================================
  Files        1036     1036           
  Lines       18771    18771           
  Branches     3556     3560    +4     
=======================================
  Hits        14729    14729           
  Misses       2844     2844           
  Partials     1198     1198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nick-Ag nick-Ag enabled auto-merge (squash) January 21, 2025 20:50
@nick-Ag nick-Ag merged commit 3ccfe18 into main Jan 21, 2025
14 checks passed
@nick-Ag nick-Ag deleted the liveramp-export-hotfix branch January 21, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants