Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix google enhanced conversion error parsing #2697

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

varadarajan-tw
Copy link
Contributor

@varadarajan-tw varadarajan-tw commented Jan 21, 2025

This PR fixes HTTP error parsing of Google Enhanced Conversions destination.

Test Doc

Testing

  • [] Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.46%. Comparing base (c80d11e) to head (1c8ee99).

Files with missing lines Patch % Lines
...tinations/google-enhanced-conversions/functions.ts 45.45% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2697      +/-   ##
==========================================
- Coverage   78.90%   78.46%   -0.44%     
==========================================
  Files        1089     1036      -53     
  Lines       21361    18717    -2644     
  Branches     4262     3551     -711     
==========================================
- Hits        16854    14687    -2167     
+ Misses       3310     2838     -472     
+ Partials     1197     1192       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant