Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect mapping in mixpanel destination #2695

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spjtls9
Copy link
Contributor

@spjtls9 spjtls9 commented Jan 20, 2025

A summary of your pull request, including the what change you're making and why.

  • width and height were incorrectly mapped to screen field.
  • Fix the error: width -> screen.width; height -> screen.height

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@spjtls9 spjtls9 changed the title Update mixpanel-properties.ts Fix incorrect mapping in mixpanel destination Jan 20, 2025
@spjtls9 spjtls9 marked this pull request as ready for review January 20, 2025 20:35
@spjtls9 spjtls9 requested a review from a team as a code owner January 20, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant