Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple Destinations] - cleaning up some test noise #2692

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

joe-ayoub-segment
Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment commented Jan 17, 2025

Cleaning up some noisy tests (console logs and other minor issues)
actable Destination will need a push.

Testing

Tested updated and all passing.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.48%. Comparing base (fdcc03e) to head (eb8a81b).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
packages/cli/src/commands/validate.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2692      +/-   ##
==========================================
- Coverage   78.52%   78.48%   -0.05%     
==========================================
  Files        1033     1036       +3     
  Lines       18702    18709       +7     
  Branches     3548     3548              
==========================================
- Hits        14686    14684       -2     
- Misses       2824     2834      +10     
+ Partials     1192     1191       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marinhero marinhero merged commit f44ad27 into main Jan 28, 2025
12 of 14 checks passed
@marinhero marinhero deleted the clean-up-test-noise branch January 28, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants