Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nikumar/client credentials #2217

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Nikumar/client credentials #2217

wants to merge 2 commits into from

Conversation

nk1107
Copy link

@nk1107 nk1107 commented Jul 25, 2024 •
edited
Loading

This PR

  1. Adds an additional field to oauthGrantType in OAuth2Authentication and OAuthManagedAuthentication which specifies the Oauth grant type followed by that Destination.
  2. It also updates the init CLI command to prompt for grant-type when authentication scheme chosen is Oauth.
  3. Also creates a new template for Destinations that follow grant type client_credentials.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
actions:core mode:cloud not-partner-eng-review (cloud) team:segment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nk1107 @joe-ayoub-segment