Prop Descriptions

[hipstersmoothie]

closes #37

I lifted the code mostly from code mirror addon xml

• Prop Type: descriptions
• Prop Type: required
• Prop Type: default
• Prop Type: type
• Component: description
• Test on vanilla JS

[hipstersmoothie]

@markdalgleish this should be all good now

[markdalgleish]

Any chance you could add an example that exercises this? Right now, it's hard for me to verify this is working as desired.

[markdalgleish]

Is this file borrowed from somewhere else? Seems like a copy-and-paste.

[hipstersmoothie]

It was the addon-xml 😅 I went back for a second look and was able to use that code once it was registered to codemirror and just handle the tooltip stuff myself.

I switched to rendering the tooltip with lit-html. I can remove that and switch back to document methods if you want, but I think the code is a little clearer this way.

[hipstersmoothie]

Actually I realized i could just use react and it become much clearer 👍

[hipstersmoothie]

Any chance you could add an example that exercises this? Right now, it's hard for me to verify this is working as desired.

Added descriptions and defaults to the typescript example.

[hipstersmoothie]

@markdalgleish Does your major re-architecture effect any of this? I'm happy to change what ever else you need me to. Really excited to get this and #55 in.

EDIT: Doesn't look like our changes conflict much. I mostly just edited playroom.js

[hipstersmoothie]

If these changes are too much a plugin API for suggestions would also probably fit my use case.

As it is playroom is only useful for people that are super familiar with the components and how they work together or have the docs up in a separate tab. Even when i try to use playroom myself I feel crippled without having the type definitions helping me along.

[yceballost]

would be nice to merge this feature <3