Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the 'org.seedsecuritylabs.seedemu.meta.class' label of containers in web app #183

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

amdfxlucas
Copy link
Contributor

Services installed on nodes have the option to set a 'class' label on the container i.e. Node::appendClassName('WebService').

Up to now this label is never used in the web client.
In order to support overlay visualizations this information is useful.

class_label

@wonkr
Copy link
Member

wonkr commented Mar 5, 2024

@amdfxlucas ,
Currently class label is used in the etherview application (https://github.com/seed-labs/seed-emulator/tree/master/tools/Blockchain/EtherView).
(I made a change it to merge into development branch instead of main branch.)
Your code seems to have upgrade the version of node js and multiple libraries of node js. We are currently being very cautious about version updates. We want to carefully review potential errors that may arise from version updates first. Due to limited manpower resources on our team, the schedule might take longer than expected. We are reviewing open issues one by one.
Thank you for your �contribution.

@wonkr wonkr changed the base branch from master to development March 5, 2024 06:39
@wonkr wonkr changed the base branch from development to client-overlay-support March 5, 2024 21:15
@wonkr
Copy link
Member

wonkr commented Mar 5, 2024

I created a new branch client-overlay-support branch to test it. I will update the test result after the test is done. Thanks.

@wonkr wonkr merged commit 0b954d8 into seed-labs:client-overlay-support Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants