[2PC] Add dispatch from DotGeneral to BatchMatmul #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntations Current DotGeneral is decomposed into seperated matmul calls But for some back-ends (e.g., Cheetah); we can do better.
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
|
Stale pull request message. Please comment to remove stale tag. Otherwise this pr will be closed soon. |
|
Stale pull request message. Please comment to remove stale tag. Otherwise this pr will be closed soon. |
|
Stale pull request message. Please comment to remove stale tag. Otherwise this pr will be closed soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[2PC] Add dispatch from DotGeneral to BatchMatmul and add some documentations.
Current DotGeneral is decomposed into seperated matmul calls.
But for some back-ends (e.g., Cheetah), we can do better than seperate calls to matmul.
Pull Request
What problem does this PR solve?
Issue Number: Fixed #
Possible side effects?
No. If the
batch_matmulkernel is not added by the MPC backend; then we simply fall back to the normal multiple calls ofmatmul.