Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【OSCP】[FNP04] 选择并在 SecretFlow 中实现多方 PSI 协议 #379

Closed
wants to merge 5 commits into from
Closed

【OSCP】[FNP04] 选择并在 SecretFlow 中实现多方 PSI 协议 #379

wants to merge 5 commits into from

Conversation

zhangwfjh
Copy link

@zhangwfjh zhangwfjh commented Oct 28, 2023 •
edited by Candicepan
Loading

@zhanglei486
Copy link
Contributor

上面CI的uinttest和我单独跑uinttest都报失败， @zhangwfjh 辛苦改进一下
image

@zhangwfjh
Copy link
Author

zhangwfjh commented Oct 30, 2023 •
edited
Loading

上面CI的uinttest和我单独跑uinttest都报失败， @zhangwfjh 辛苦改进一下 image

image
我本地跑没问题，yacl的timeout是多长时间？我尝试再优化下。CI的test.log可以看得到吗?

@zhanglei486
Copy link
Contributor

CI的test.log可以看得到吗?

有耗时的计算任务时， 可以使用SyncWait 防止link timeout
https://github.com/secretflow/spu/blob/main/libspu/psi/utils/utils.h#L63

@zhanglei486
Copy link
Contributor

建议增加fnp04_mp_psi_bench.cc， 测试一下十万、百万、千万量级的运行是否正常以及性能表现
可以参加ecdh_psi_bench和kkrt_psi_bench
https://github.com/secretflow/spu/blob/main/libspu/psi/core/ecdh_psi_bench.cc

https://github.com/secretflow/spu/blob/main/libspu/psi/core/kkrt_psi_bench.cc

@github-actions GitHub Actions
Copy link

Stale pull request message. Please comment to remove stale tag. Otherwise this pr will be closed soon.

@github-actions github-actions bot closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhanglei486 zhanglei486 zhanglei486 left review comments

Assignees
No one assigned
Labels
no-pr-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FNP04]选择并在 SecretFlow 中实现多方 PSI 协议
2 participants
@zhangwfjh @zhanglei486