-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logistic regression multi classification ovr #368
Merged
deadlywing
merged 4 commits into
secretflow:main
from
magic-hya:logistic_multi_class_ovr
Oct 30, 2023
Merged
Add logistic regression multi classification ovr #368
deadlywing
merged 4 commits into
secretflow:main
from
magic-hya:logistic_multi_class_ovr
Oct 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: magic-hya <[email protected]>
目前遇到问题:
其中校验函数的默认参数为 rtol=1.e-5
|
deadlywing
reviewed
Oct 19, 2023
@magic-hya Hi,抱歉前段时间比较忙,review不及时,一些意见供参考,欢迎讨论~ |
Signed-off-by: magic-hya <[email protected]>
Signed-off-by: magic-hya <[email protected]>
deadlywing
reviewed
Oct 25, 2023
Signed-off-by: magic-hya <[email protected]>
deadlywing
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What problem does this PR solve?
增加多分类ovr功能
Issue Number: Fixed #252
Possible side effects?
Performance:
Backward compatibility: