Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Helm chart namespace and handle webhooks certificates creation #103

Merged
merged 1 commit into from
May 14, 2024

Conversation

kvaps
Copy link
Contributor

@kvaps kvaps commented May 14, 2024

  • Remove namespace options, use {{ .Release.Namespace }} instead
  • Use kube-webhook-certgen for generating certificates and inject them into webhook configuration

@chrislusf chrislusf merged commit 8211c1f into seaweedfs:master May 14, 2024
2 of 5 checks passed
@chrislusf
Copy link
Collaborator

Thanks for the fix! Please split similar PRs later if there are more than one changes.

@okgolove
Copy link

Hello @kvaps. I've noticed at the very first install with enabled webhook deployment fails to start. The workaround is to disable, install, then enable again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants