Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I've made a bunch of small tweaks that, hopefully, will make themes more coherent. Also, I've reduced code duplication in italic/non italic versions of themes - now they use inheritance:
Night Owl.noitalic.color-theme.json
depends on:
Night Owl.color-theme.json
For now its implemented thru undocumented
include
property of theme files. Hopefully that will make theme tweaking easier.Here is a bunch of small tweak, some of them may resolve opened issues:
console.log
, now use coherent function invocation coloringfor of this
) now using coherent coloringclass
type tokens now have distinguishable pinkish coloringconsole
now have distinguishable greenish coloringHere is screenshots of light/dark themes for comparison. "Before" on the left side.