Skip to content

Commit

Permalink
[CI] Update Verbosity
Browse files Browse the repository at this point in the history
This PR updates the Github actions CI to no longer check for 
indentation and naming convention. We also removed the comment bot.

Commit log:

* Updated verbosity level

* Update verbosity

* Update verbosity

* Removed Comment action

* Testing Comment Bot

* Testing comment bot

* Testing

* Testing

* Testing

* Testing

* Removed Comment bot
  • Loading branch information
bdevierno1 authored May 12, 2020
1 parent e574c6f commit 08bf7ab
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 19 deletions.
19 changes: 3 additions & 16 deletions .github/workflows/Linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,9 @@ jobs:
# If Branch name is not develop, comment
- name: Test Branch Name
if: github.base_ref != 'develop'
uses: mshick/add-pr-comment@v1
with:
message: |
**Please Set PR to develop. 😊**
repo-token: ${{ secrets.GITHUB_TOKEN }}
run: |
echo 'Please PR on develop branch.'
exit 1
C:
runs-on: ubuntu-latest
steps:
Expand All @@ -26,7 +24,6 @@ jobs:
chmod +x style/run-lint.sh
style/run-lint.sh c
Cppcheck:
needs: [Branch]
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand Down Expand Up @@ -68,13 +65,3 @@ jobs:
run: |
chmod +x style/run-lint.sh
style/run-lint.sh shell
Comment:
needs: [Branch,C,Cppcheck,Python,Shell]
runs-on: ubuntu-latest
steps:
- name: Add Comment
uses: mshick/add-pr-comment@v1
with:
message: |
**All Lint Tests Passed!🚀**
repo-token: ${{ secrets.GITHUB_TOKEN }}
1 change: 0 additions & 1 deletion style/github-action-style.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ The workflow has five separate jobs that run concurrently.
* **C** -- Lints C files for styling errors with gwclint.py
* **Python** -- Lints Python files with pylint.
* **Shell** -- Lints bash shell script files with shellcheck
* **Comment** -- If all five previous jobs have passed, comment 'All Lint Tests Passed'


## Other Resources
Expand Down
2 changes: 1 addition & 1 deletion style/run-lint.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def gwlint_output(file_name):
lint_lines = os.popen(get_python_lint_cmd).read().splitlines()

# If lint with gwclint remove the last line of lint: "Done processing example-filename.c"
if sys.argv[1] == "python ./style/gwclint.py --verbose=2":
if sys.argv[1] == "python ./style/gwclint.py --verbose=4":
lint_lines = lint_lines[:-1]
# If linting with cppcheck, we only want errors. Remove lines such as Checking..."
elif sys.argv[1] == "cppcheck":
Expand Down
2 changes: 1 addition & 1 deletion style/run-lint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ case "$1" in
python3 "style/run-lint.py" "pylint" "*.py"
;;
"c") echo $'Running C Lint.\n'
python3 "style/run-lint.py" "python ./style/gwclint.py --verbose=2" "'*.c' '*.cpp' '*.h' | grep -v 'cJSON' | grep -v 'ndpi'"
python3 "style/run-lint.py" "python ./style/gwclint.py --verbose=4" "'*.c' '*.cpp' '*.h' | grep -v 'cJSON' | grep -v 'ndpi'"
;;
"cppcheck") echo $'Running cppcheck Lint.\n'
python3 "style/run-lint.py" "cppcheck" "'*.c' '*.cpp' '*.h' | grep -v 'cJSON' | grep -v 'ndpi'"
Expand Down

0 comments on commit 08bf7ab

Please sign in to comment.