restore: CQL session created out of rpc_addresses #3418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3411
This PR extends docker-compose.yaml used for integration-tests to include additional network.
Scylla's
listen_address
belongs tosecond
network.Scylla's
rpc_address
belongs topublic
network.Scylla uses
rpc_address
to accept CQL connections whenlisten_address
is used for node2node communication.Issue #3411 showed that restore procedure in scylla-manager doesn't support such a setup.
This PR addresses that by querying ScyllaAPI to get the RPC address when creating CQL session.
Integration-tests are updated to work fine on current docer-compose environment.
db.go
fromtestutils
is moved to another packagetestutils/db
to avoid import cycle."Only the Best is Good Enough." - LEGO company motto
Please make sure that: