Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix suffix concatenate when each table annotates > 1 elements #873

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

LucaMarconato
Copy link
Member

Closes #414
Bug reported by @AmosFong1 (thanks!)

@LucaMarconato LucaMarconato enabled auto-merge (squash) February 11, 2025 15:07
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.96%. Comparing base (fd6222d) to head (55bc3e9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #873   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files          47       47           
  Lines        7355     7359    +4     
=======================================
+ Hits         6764     6768    +4     
  Misses        591      591           
Files with missing lines Coverage Δ
src/spatialdata/_core/concatenate.py 92.06% <100.00%> (+0.26%) ⬆️

@LucaMarconato LucaMarconato merged commit 24fb4d1 into main Feb 11, 2025
7 checks passed
@LucaMarconato LucaMarconato deleted the fix/suffix-concatenate branch February 11, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concatenating Multiple Spatialdata objects: Regions in the AnnData object and cells_region do not match.
1 participant