Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JoinTypes.__dict__ empty python 3.13 #853

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

LucaMarconato
Copy link
Member

Hotfix for #852

@LucaMarconato
Copy link
Member Author

LucaMarconato commented Jan 30, 2025

Ah no, I see that multiscale-spatial-image does not support Python 3.13: https://github.com/spatial-image/multiscale-spatial-image/blob/main/pyproject.toml.

I missed this when I made this PR: #840. We need either to revert that PR or to check if multiscale-spatial-image can support Python 3.13. I tracked this here: spatial-image/multiscale-spatial-image#104.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (7c280b7) to head (bc5a917).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #853   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files          47       47           
  Lines        7293     7293           
=======================================
  Hits         6706     6706           
  Misses        587      587           
Files with missing lines Coverage Δ
src/spatialdata/_core/query/relational_query.py 90.78% <100.00%> (ø)

@LucaMarconato LucaMarconato marked this pull request as draft January 30, 2025 13:59
@LucaMarconato LucaMarconato merged commit 412bf45 into main Jan 31, 2025
7 of 8 checks passed
@LucaMarconato LucaMarconato deleted the fix/join_empty_dict branch January 31, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant