Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize #52

Merged
merged 18 commits into from
Feb 26, 2025
Merged

Modernize #52

merged 18 commits into from
Feb 26, 2025

Conversation

Gallaecio
Copy link
Contributor

@Gallaecio Gallaecio commented Feb 25, 2025

Includes #51 since it is necessary to support the latest version of Scrapy.

Closes #51 (if not merged first), closes #50, fixes #49.

@Gallaecio Gallaecio marked this pull request as ready for review February 26, 2025 00:01
@Gallaecio Gallaecio requested review from kmike, wRAR and pawelmhm February 26, 2025 00:01
Copy link
Member

@kmike kmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.71%. Comparing base (28d2fd0) to head (7f0211c).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
scrapy_deltafetch/middleware.py 97.05% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   91.30%   95.71%   +4.40%     
==========================================
  Files           2        2              
  Lines          69       70       +1     
  Branches        9        8       -1     
==========================================
+ Hits           63       67       +4     
+ Misses          3        0       -3     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gallaecio Gallaecio merged commit fc6065d into master Feb 26, 2025
12 checks passed
@Gallaecio Gallaecio deleted the modernize branch February 26, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request fingerprint does not work with other item types except scrapy.item.Item
5 participants