Merge branch 'main' of github.com:sartography/github-actions-library

sartography · Aug 16, 2024 · 02d68df · 02d68df
2 parents cc8cfeb + 3285d7d
commit 02d68df
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -12,7 +12,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       # - name: Run ECR Scan and Get SARIF Report
       #   uses: sartography/github-actions-library/wait-for-ecr-scan-and-get-sarif@main
@@ -40,7 +40,7 @@ jobs:
             --output_file report.sarif
 
       - name: Upload SARIF report as artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: sarif-report
           path: report.sarif

diff --git a/.github/workflows/unit_test.yml b/.github/workflows/unit_test.yml
@@ -14,7 +14,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Set up Python 3.12
         uses: actions/[email protected]

diff --git a/wait-for-ecr-scan-and-get-sarif/README.md b/wait-for-ecr-scan-and-get-sarif/README.md
@@ -40,28 +40,22 @@ on:
   push:
     branches:
       - main
-  workflow_dispatch:
+
 jobs:
   ecr-scan:
     runs-on: ubuntu-latest
 
     steps:
       # [Probably build and push image to ECR here]
 
-      - name: Run ECR Scan and Get SARIF Report
+      - name: Wait for ECR Scan and Get SARIF Report
         uses: sartography/github-actions-library/wait-for-ecr-scan-and-get-sarif@main
         with:
           repository_name: "infr/testcloud2202"
           image_tag: "main"
           aws_region: "us-east-2"
           output_file: "report.sarif"
 
-      - name: Upload SARIF report as artifact
-        uses: actions/upload-artifact@v3
-        with:
-          name: sarif-report
-          path: report.sarif
-
       - name: Upload SARIF file
         uses: github/codeql-action/upload-sarif@v3
         with: