Skip to content

Commit

Permalink
.Net: Fix PlannerInstrumentation log message typo (microsoft#4904)
Browse files Browse the repository at this point in the history
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
There are two typos in the `PlannerInstrumentation` log message
templates, which causes confusion.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
Fix the typos.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

Co-authored-by: Chris <[email protected]>
Co-authored-by: Gil LaHaye <[email protected]>
  • Loading branch information
3 people authored Feb 7, 2024
1 parent 7e43195 commit dcd7e14
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -204,13 +204,13 @@ private static void LogPlanResult(this ILogger logger, object planResult)
[LoggerMessage(
EventId = 0,
Level = LogLevel.Error,
Message = "Plan creation failed. Error: {Message}")]
Message = "Plan execution failed. Error: {Message}")]
static partial void LogInvokePlanError(this ILogger logger, Exception exception, string message);

[LoggerMessage(
EventId = 0,
Level = LogLevel.Information,
Message = "Plan creation duration: {Duration}s.")]
Message = "Plan execution duration: {Duration}s.")]
static partial void LogInvokePlanDuration(this ILogger logger, double duration);

#pragma warning restore SYSLIB1006 // Multiple logging methods cannot use the same event id within a class
Expand Down

0 comments on commit dcd7e14

Please sign in to comment.