chore(config): Update pre-commit hooks version #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update `trailing-whitespace` hook to latest stable version (v5.0.0)
![mentatbot[bot]](https://avatars.githubusercontent.com/in/837875?s=60&v=4){kind=small}
There was a problem hiding this comment.
The version update looks good, but since it's a major version bump, we should ensure all hooks we're using are still compatible. Also, while we're updating dependencies, it might be worth checking if the typos hook (currently at v1.26.0) also has updates available.
Thanks for using MentatBot. Give comments a 👍 or 👎 to help me improve!
| @@ -2,7 +2,7 @@ | |||
| repos: | |||
| # Standard pre-commit hooks for generic tasks | |||
| - repo: https://github.com/pre-commit/pre-commit-hooks | |||
| rev: v4.4.0 # Use the latest stable version | |||
| rev: v5.0.0 # Use the latest stable version | |||
There was a problem hiding this comment.
Since this is a major version bump (v4.4.0 -> v5.0.0), it would be helpful to include a link to the changelog or mention any breaking changes in the commit message. Also, consider updating the comment to specify 'Latest stable version as of ' to provide more context.
Suggested change
| rev: v5.0.0 # Use the latest stable version | |
| rev: v5.0.0 # Latest stable version as of 2024-01 (v5.0.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trailing-whitespacehook to latest stable version (v5.0.0)