Stop using std::tmpnam in POSIX operating systems

include/Sand/Helpers.hpp

@@ -4,23 +4,9 @@
 
 namespace Sand::Helpers
 {
-bool ends_with(const std::string &str, const std::string &ending)
-{
-    if (str.length() >= ending.length())
-    {
-        return str.compare(str.length() - ending.length(), ending.length(), ending) == 0;
-    }
-
-    return false;
-}
+bool ends_with(const std::string &str, const std::string &ending);
 
-bool starts_with(const std::string &str, const std::string &starting)
-{
-    if (str.length() >= starting.length())
-    {
-        return str.rfind(starting, 0) == 0;
-    }
+bool starts_with(const std::string &str, const std::string &starting);
 
-    return false;
-}
+std::string temporary_filename();
 } // namespace Sand::Helpers

src/Compiler.cpp

@@ -1,5 +1,7 @@
 #include <Sand/Compiler.hpp>
 
+#include <Sand/Helpers.hpp>
+
 #include <llvm/IR/LegacyPassManager.h>
 #include <llvm/IR/PassManager.h>
 #include <llvm/Passes/PassBuilder.h>
@@ -28,7 +30,7 @@ std::vector<std::string> Sand::Compiler::generate_objects(const std::string &os,
         std::cout << "Target triple: " << this->module->getTargetTriple() << std::endl;
     }
 
-    std::string output_path = std::tmpnam(nullptr);
+    auto output_path = Helpers::temporary_filename();
     std::error_code error_code;
     llvm::raw_fd_ostream dest(output_path, error_code, llvm::sys::fs::OF_None);
 

src/Helpers.cpp

@@ -0,0 +1,40 @@
+#include <Sand/Helpers.hpp>
+
+#include <Sand/filesystem.hpp>
+
+#include <cstdio>
+#include <cstdlib>
+
+using namespace Sand;
+
+bool Helpers::ends_with(const std::string &str, const std::string &ending)
+{
+    if (str.length() >= ending.length())
+    {
+        return str.compare(str.length() - ending.length(), ending.length(), ending) == 0;
+    }
+
+    return false;
+}
+
+bool Helpers::starts_with(const std::string &str, const std::string &starting)
+{
+    if (str.length() >= starting.length())
+    {
+        return str.rfind(starting, 0) == 0;
+    }
+
+    return false;
+}
+
+std::string Helpers::temporary_filename()
+{
+#if defined(WIN32) || defined(_WIN32) || defined(__WIN32) && !defined(__CYGWIN__)
+    return std::tmpnam(nullptr);
+#else
+    auto filename = fs::temp_directory_path().u8string() + "XXXXXXXXXXXXXXXX";
+    mkstemp(filename.data());
+
+    return filename;
+#endif
+}

src/main.cpp

@@ -7,6 +7,8 @@
 #include <Sand/Debugger.hpp>
 #include <Sand/Linker.hpp>
 
+#include <Sand/Helpers.hpp>
+
 #include <Sand/Exceptions/CompilationException.hpp>
 #include <Sand/Exceptions/TargetLookupFailedException.hpp>
 
@@ -297,7 +299,7 @@ int main(int argc, char **argv)
     run->add_flag("--verbose", options.verbose, "Verbose mode");
 
     run->callback([&]() {
-        options.output_file = std::tmpnam(nullptr);
+        options.output_file = Sand::Helpers::temporary_filename();
 
         if (!compile(options, debug))
         {