Skip to content

Commit

Permalink
Merge pull request ESCOMP#2758 from cathyxinchangli/dehumidification_…
Browse files Browse the repository at this point in the history 
…ctrl_bugfix

clm5.3.024: Change the choice of pressure in CLMU building energy model (BEM)
  • Loading branch information
@slevis-lmwg
slevis-lmwg authored Feb 11, 2025
2 parents af94e3c + 41972c9 commit 70b8730
Show file tree
Hide file tree
Showing 4 changed files with 78 additions and 7 deletions.
68 changes: 67 additions & 1 deletion doc/ChangeLog
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,70 @@
===============================================================
Tag name: ctsm5.3.024
Originator(s): xinchang (Cathy Xinchang Li, U of Illinois - Urbana-Champaign)
Date: Tue Feb 11 09:56:24 MST 2025
One-line Summary: Change choice of pressure in CLMU building energy model

Purpose and description of changes
----------------------------------

In the CLMU Building Energy Model (BEM), the choice of pressure for calculating indoor air density is changed from standard pressure to bottom layer of atmosphere pressure of the corresponding grid cell.

Significant changes to scientifically-supported configurations
--------------------------------------------------------------

Does this tag change answers significantly for any of the following physics configurations?
(Details of any changes will be given in the "Answer changes" section below.)

[Put an [X] in the box for any configuration with significant answer changes.]

[ ] clm6_0

[ ] clm5_0

[ ] ctsm5_0-nwp

[ ] clm4_5

Bugs fixed
----------
List of CTSM issues fixed (include CTSM Issue # and description) [one per line]:
Resolves #2755

Notes of particular relevance for users
---------------------------------------
Changes to documentation:
From the PR: I have updated the inline documentation in the code where it's needed

Testing summary:
----------------
[PASS means all tests PASS; OK means tests PASS other than expected fails.]

regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing):

derecho ----- OK
izumi ------- OK

Answer changes
--------------

Changes answers relative to baseline: Yes

Summarize any changes to answers, i.e.,
- what code configurations: all
- what platforms/compilers: all
- nature of change: larger than roundoff/same climate

From the PR: Some urban variables such as urban 2m air temperature, 2m relative humidity, urban air-conditioning and heating energy fluxes will change slightly. See #2755 for details.

slevis from running aux_clm: I see larger differences that seem justified as simulations typically diverge from small initial differences.

Other details
-------------
Pull Requests that document the changes (include PR ids):
https://github.com/ESCOMP/ctsm/pull/2758

===============================================================
===============================================================
Tag name: ctsm5.3.023
Originator(s): afoster (Adrianna Foster)
Date: Sat Feb 8 08:36:00 MST 2025
Expand Down Expand Up @@ -4220,7 +4286,7 @@ Pull Requests that document the changes (include PR ids):
===============================================================
===============================================================
Tag name: ctsm5.2.010
Originator(s): @cathyxinchangli (Cathy Xinchang Li, U of Illinois - Urbana-Champaign), @Face2sea, @olyson, @fang-bowen, @keerzhang1
Originator(s): xinchang (Cathy Xinchang Li, U of Illinois - Urbana-Champaign), @Face2sea, @olyson, @fang-bowen, @keerzhang1
Date: Thu 11 Jul 2024 11:57:15 AM MDT
One-line Summary: Explicit A/C adoption

Expand Down
1 change: 1 addition & 0 deletions doc/ChangeSum
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Tag Who Date Summary
============================================================================================================================
ctsm5.3.024 xinchang 02/11/2025 Change choice of pressure in CLMU building energy model
ctsm5.3.023 afoster 02/08/2025 merge b4b-dev
ctsm5.3.022 glemieux 02/06/2025 Update FATES namelist build to avoid Meier2022
ctsm5.3.021 samrabin 01/29/2025 Standardize time metadata (release tag for ctsm5.3)
Expand Down
2 changes: 1 addition & 1 deletion src/biogeophys/SoilTemperatureMod.F90
View file
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ subroutine SoilTemperature(bounds, num_urbanl, filter_urbanl, num_urbanc, filter
if ( IsProgBuildTemp() )then
call BuildingTemperature(bounds, num_urbanl, filter_urbanl, num_nolakec, filter_nolakec, &
tk(bounds%begc:bounds%endc, :), urbanparams_inst, &
temperature_inst, energyflux_inst, urbantv_inst)
temperature_inst, energyflux_inst, urbantv_inst, atm2lnd_inst)
end if

do fc = 1,num_nolakec
Expand Down
14 changes: 9 additions & 5 deletions src/biogeophys/UrbBuildTempOleson2015Mod.F90
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module UrbBuildTempOleson2015Mod
use UrbanTimeVarType , only : urbantv_type
use EnergyFluxType , only : energyflux_type
use TemperatureType , only : temperature_type
use atm2lndType , only : atm2lnd_type
use LandunitType , only : lun
use ColumnType , only : col
!
Expand All @@ -42,7 +43,7 @@ module UrbBuildTempOleson2015Mod
! !INTERFACE:
subroutine BuildingTemperature (bounds, num_urbanl, filter_urbanl, num_nolakec, &
filter_nolakec, tk, urbanparams_inst, temperature_inst, &
energyflux_inst, urbantv_inst)
energyflux_inst, urbantv_inst, atm2lnd_inst)
!
! !DESCRIPTION:
! Solve for t_building, inner surface temperatures of roof, sunw, shdw, and floor temperature
Expand Down Expand Up @@ -202,7 +203,7 @@ subroutine BuildingTemperature (bounds, num_urbanl, filter_urbanl, num_nolakec,
! !USES:
use shr_kind_mod , only : r8 => shr_kind_r8
use clm_time_manager, only : get_step_size_real
use clm_varcon , only : rair, pstd, cpair, sb, hcv_roof, hcv_roof_enhanced, &
use clm_varcon , only : rair, cpair, sb, hcv_roof, hcv_roof_enhanced, &
hcv_floor, hcv_floor_enhanced, hcv_sunw, hcv_shdw, &
em_roof_int, em_floor_int, em_sunw_int, em_shdw_int, &
dz_floor, dens_floor, cp_floor, vent_ach
Expand All @@ -224,10 +225,11 @@ subroutine BuildingTemperature (bounds, num_urbanl, filter_urbanl, num_nolakec,
type(temperature_type), intent(inout) :: temperature_inst ! temperature variables
type(energyflux_type) , intent(inout) :: energyflux_inst ! energy flux variables
type(urbantv_type) , intent(in) :: urbantv_inst ! urban time varying variables
type(atm2lnd_type) , intent(in) :: atm2lnd_inst ! forcing variables from atmosphere
!
! !LOCAL VARIABLES:
integer, parameter :: neq = 5 ! number of equation/unknowns
integer :: fc,fl,c,l ! indices
integer :: fc,fl,c,l,g ! indices
real(r8) :: dtime ! land model time step (s)
real(r8) :: building_hwr(bounds%begl:bounds%endl) ! building height to building width ratio (-)
real(r8) :: t_roof_inner_bef(bounds%begl:bounds%endl) ! roof inside surface temperature at previous time step (K)
Expand Down Expand Up @@ -310,6 +312,7 @@ subroutine BuildingTemperature (bounds, num_urbanl, filter_urbanl, num_nolakec,
ctype => col%itype , & ! Input: [integer (:)] column type
zi => col%zi , & ! Input: [real(r8) (:,:)] interface level below a "z" level (m)
z => col%z , & ! Input: [real(r8) (:,:)] layer thickness (m)
forc_pbot => atm2lnd_inst%forc_pbot_not_downscaled_grc, & ! Input: [real(r8) (:)] atmospheric pressure (Pa)

ht_roof => lun%ht_roof , & ! Input: [real(r8) (:)] height of urban roof (m)
canyon_hwr => lun%canyon_hwr , & ! Input: [real(r8) (:)] ratio of building height to street hwidth (-)
Expand Down Expand Up @@ -348,6 +351,7 @@ subroutine BuildingTemperature (bounds, num_urbanl, filter_urbanl, num_nolakec,
! 5. Calculate building height to building width ratio
do fl = 1,num_urbanl
l = filter_urbanl(fl)
g = lun%gridcell(l)
if (urbpoi(l)) then
t_roof_inner_bef(l) = t_roof_inner(l)
t_sunw_inner_bef(l) = t_sunw_inner(l)
Expand Down Expand Up @@ -376,8 +380,8 @@ subroutine BuildingTemperature (bounds, num_urbanl, filter_urbanl, num_nolakec,
cp_floori(l) = cp_floor
! Intermediate calculation for concrete floor (W m-2 K-1)
cv_floori(l) = (dz_floori(l) * cp_floori(l)) / dtime
! Density of dry air at standard pressure and t_building (kg m-3)
rho_dair(l) = pstd / (rair*t_building_bef(l))
! Density of dry air at surface pressure and t_building (kg m-3)
rho_dair(l) = forc_pbot(g) / (rair*t_building_bef(l))
! Building height to building width ratio
building_hwr(l) = canyon_hwr(l)*(1._r8-wtlunit_roof(l))/wtlunit_roof(l)
end if
Expand Down

0 comments on commit 70b8730

Please sign in to comment.