Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts.CompilerHost.jsDocParsingMode #683

Merged
merged 1 commit into from
Nov 8, 2023
Merged

ts.CompilerHost.jsDocParsingMode #683

merged 1 commit into from
Nov 8, 2023

Conversation

samchon
Copy link
Owner

@samchon samchon commented Nov 8, 2023

Since TypeScript v5.3 update, TypeScript compiler no more analyzes JsDocComment as default.

The desire of that is to boosting up the compilation speed by not parsing the JS Doc Comments.

Therefore, to parepare the future TypeScript v5.3 release, I've updated @nestia/sdk to configure the jsDocParsingMode to parse every comments manually. For reference, the restriction of peerDependencies -> "typescript": ">=4.8.0 <5.3.0" would also be erased after formal TS v5.3 release.

microsoft/TypeScript#55739

Since TypeScript v5.3 update, TypeScript compiler no more analyzes `JsDocComment` as default to boost up compilation speed by not parsing the JS Doc Comments.

Therefore, to parepare the future TypeScript v5.3 release, I've updated `@nestia/sdk` to configure the `jsDocParsingMode` to parse every comments manually.

microsoft/TypeScript#55739
@samchon samchon added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 8, 2023
@samchon samchon self-assigned this Nov 8, 2023
@samchon samchon merged commit 6312fb1 into master Nov 8, 2023
@jakebailey
Copy link

The API will still parse JSDoc by default; only tsc has this disabled (and it's likely ts-patch will undo that change). You shouldn't need to do anything on your side.

@samchon
Copy link
Owner Author

samchon commented Nov 8, 2023

The API will still parse JSDoc by default; only tsc has this disabled (and it's likely ts-patch will undo that change). You shouldn't need to do anything on your side.

Ah, got it. Thanks for detailed info.

@samchon samchon added the invalid This doesn't seem right label Nov 8, 2023
@samchon samchon deleted the features/jsDoc branch November 21, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants