-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape spaces found while parsing GPO XMLNS tags #67129
base: 3006.x
Are you sure you want to change the base?
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
Let me know if you need help writing tests for this. Looks like a simple unit test on the |
Also, let's make this fix on the 3006.x branch. |
eddd1b2
to
671e5f7
Compare
671e5f7
to
aeb4b8f
Compare
OK, I added a test and created a change log. I also rebased on the 3006.x branch. |
What does this PR do?
What issues does this PR fix or reference?
Escapes spaces found in XMLNS urls in Windows GPO documents with
%20
Closes #66992
Previous Behavior
Spaces would not be escaped, breaking lgpo state application.
New Behavior
Spaces are properly escaped allow lgpo state application to operate correctly.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.