Feat/import signers #4857
Open
Feat/import signers #4857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resentational layer
Branch preview✅ Deploy successful! Storybook: |
Coverage (44%)
|
compojoom
reviewed
Jan 31, 2025
Comment on lines
+65
to
+89
| <Stack.Screen | ||
| name="import-signers/import-private-key" | ||
| options={{ headerShown: true, title: '' }} | ||
| /> | ||
| <Stack.Screen | ||
| name="import-signers/import-private-key-success" | ||
| options={{ | ||
| presentation: 'modal', | ||
| headerShown: false, | ||
| }} | ||
| /> | ||
| <Stack.Screen | ||
| name="import-signers/loading-import" | ||
| options={{ | ||
| presentation: 'modal', | ||
| headerShown: false, | ||
| }} | ||
| /> | ||
| <Stack.Screen | ||
| name="import-signers/import-private-key-error" | ||
| options={{ | ||
| presentation: 'modal', | ||
| headerShown: false, | ||
| }} | ||
| /> |
There was a problem hiding this comment.
Just a nit.
We'll have quite some typing with those names.
the folder name is import-signers. Repeating import in the file name afterwards looks redundant.
import-signers/private-key
import-signers/private-key-success
import-signers/loading
import-signers/private-key-error
convey the same meaning in my opinion.
compojoom
reviewed
Jan 31, 2025
| const items = [ | ||
| { | ||
| name: 'seed', | ||
| title: 'Import seed phrase or a private key', | ||
| description: 'Enter a private key or a 12-24 word seed phrase.', | ||
| icon: <SafeFontIcon name="wallet" size={16} />, | ||
| Image: Seed, | ||
| imageProps: { marginBottom: -31 }, |
There was a problem hiding this comment.
why is it -31 here and -48 for the next image. Is this going to look ok on a smaller, bigger display? I guess you are adding those because of the safe area?
compojoom
reviewed
Jan 31, 2025
Comment on lines
+5
to
+9
| jest.mock('@/src/navigation/useScrollableHeader', () => ({ | ||
| useScrollableHeader: () => ({ | ||
| handleScroll: jest.fn(), | ||
| }), | ||
| })) |
There was a problem hiding this comment.
maybe we should move this to a global mock. We have a lot of screens with this hook now.
compojoom
reviewed
Jan 31, 2025
| act(() => fireEvent.press(button)) | ||
|
|
||
| await waitFor(() => { | ||
| expect(screen.getByTestId('safe-input').props.style.borderTopColor).toBe('#FF5F72') |
There was a problem hiding this comment.
I don't like this. I see that we did the same in the SafeWalletInput PR, but the problem is that the moment we go for a different border color those tests will fail. I think that instead we should read the color variable in tamagui here.
compojoom
reviewed
Jan 31, 2025
| <ScrollView contentContainerStyle={{ flexGrow: 1 }}> | ||
| <View flex={1} flexGrow={1} alignItems="center" justifyContent="center" paddingHorizontal="$3"> | ||
| <View flexDirection="row" alignItems="center" gap="$3"> | ||
| <Identicon address="0x0000000000000000000000000000000000000000" size={64} /> |
There was a problem hiding this comment.
Why are we generating an identicon of the 0x0 address? Later we say - the address is not a signer of this account. I would expect that we generate an identicon from the provided private key
compojoom
reviewed
Jan 31, 2025
|
|
||
| <Badge | ||
| circleProps={{ backgroundColor: '#2F2527' }} | ||
| themeName="badge_success" |
There was a problem hiding this comment.
badge success on error page?
compojoom
reviewed
Jan 31, 2025
Comment on lines
+15
to
+18
| const { data } = useSafesGetSafeV1Query({ | ||
| safeAddress: activeSafe.address, | ||
| chainId: activeSafe.chainId, | ||
| }) |
There was a problem hiding this comment.
What happens if that call fails with a network error? And why do we need to do a network request here? How did we get to the import page? We start from a safe, so we most probably have the safe in the store, no?
compojoom
reviewed
Jan 31, 2025
| "packageManager": "[email protected]" | ||
| "packageManager": "[email protected]", | ||
| "dependencies": { | ||
| "expo-linear-gradient": "~14.0.2" |
There was a problem hiding this comment.
this must be some kind of a mistake. It should be in apps/mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
It creates the import signers flow.
How to test it
Checklist