Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI maintenance #368

Merged
merged 21 commits into from
Jan 13, 2025
Merged

CI maintenance #368

merged 21 commits into from
Jan 13, 2025

Conversation

relf
Copy link
Member

@relf relf commented Jan 9, 2025

  • Make clippy happy
  • Bump MSRV to 1.71.1
  • Pin sprs to 1.11.1 version (1.11.2 pulls ndarray 0.16.1 which makes linfa-kernel compilation fail)
  • Fix code coverage (?)

@relf relf marked this pull request as ready for review January 10, 2025 07:51
@relf relf changed the title CI maintainance CI maintenance Jan 10, 2025
@quietlychris
Copy link
Member

quietlychris commented Jan 12, 2025

Looks good to me! The one comment I have is that switching from Vec to &[] can sometimes make things a little less flexible/more finicky, but I guess it make more sense to be consistent. Was that change motivated by clippy lints? Feel free to merge whenever works!

@quietlychris
Copy link
Member

Also, it's interesting that sprs = 1.11.2 is breaks things. It's dependency is labeled at ndarray = ">=0.15.0, <0.17", so I understand why ndarray 0.16.1 is an option, but in theory it should just accept linfa's existing ndarray dependency number for 0.15. Definitely having a patch bump shouldn't result in a break per SemVer guidelines.

@relf
Copy link
Member Author

relf commented Jan 13, 2025

Was that change motivated by clippy lints?

Yes (useless_vec), the change was without sensible side-effect, so...

Also, it's interesting that sprs = 1.11.2 is breaks things [...] Definitely having a patch bump shouldn't result in a break per SemVer guidelines.

I do not understand why ndarray 0.15 is not selected by sprs dependency, either.

@relf relf merged commit 1c459a8 into rust-ml:master Jan 13, 2025
20 checks passed
@relf relf deleted the ci-maintainance branch January 13, 2025 09:24
@relf relf mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants