Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and improve debuginfo tests for Windows #135192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdupak-ms
Copy link

Adds new test for closures and function pointers.
Improves robustness of existing tests by sorting wildcard matched outputs.

@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 7, 2025
@jdupak-ms
Copy link
Author

CC @wesleywiser

@jieyouxu jieyouxu added O-windows Operating system: Windows A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) labels Jan 7, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these tests need to be gated by some kind of minimum cdb version?

@jieyouxu jieyouxu added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jan 7, 2025
@jdupak-ms
Copy link
Author

Do these tests need to be gated by some kind of minimum cdb version?

They should not. I will try to get some old cdb and verify.

@jieyouxu
Copy link
Member

jieyouxu commented Jan 7, 2025

FTR, that is mostly relevant in periods of times where our CI has like a weird mix of 2 cdb versions, e.g. when github gradually rolls out Windows server version bumps. Probably not needed in this case.

Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdupak-ms! I don't see anything here that should require a particularly recent version of cdb to work but if you can test on an older version, that would be great!

If not, let us know and we can merge.

@jieyouxu
Copy link
Member

jieyouxu commented Jan 8, 2025

I don't really expect a cdb version problem since we're currently not in a cdb transition period, so let's just send this off to see if this passes full CI.

@bors r=@wesleywiser rollup=iffy (debuginfo windows tests)

@bors
Copy link
Contributor

bors commented Jan 8, 2025

📌 Commit f86ca11 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2025
@jdupak-ms
Copy link
Author

I don't really expect a cdb version problem since we're currently not in a cdb transition period, so let's just send this off to see if this passes full CI.

@bors r=@wesleywiser rollup=iffy (debuginfo windows tests)

OK, sorry for the delay. I had trouble with getting the older cdb to be picked up on my machine.

@jieyouxu
Copy link
Member

jieyouxu commented Jan 8, 2025

OK, sorry for the delay. I had trouble with getting the older cdb to be picked up on my machine.

Thanks for trying anyway!

@bors
Copy link
Contributor

bors commented Jan 8, 2025

⌛ Testing commit f86ca11 with merge 7d9573b...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2025
Add and improve debuginfo tests for Windows

Adds new test for closures and function pointers.
Improves robustness of existing tests by sorting wildcard matched outputs.
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
fmt check
fmt: skipped untracked file AWSCLIV2.pkg
fmt: checked 5760 files
tidy check
tidy error: /Users/runner/work/rust/rust/tests/debuginfo/type-names.rs:172: line longer than 100 chars
tidy error: /Users/runner/work/rust/rust/tests/debuginfo/lexical-scope-in-if-let.rs:50: line longer than 100 chars
some tidy checks failed
Command has failed. Rerun with -v to see more details.
  local time: Wed Jan  8 15:28:27 UTC 2025
  network time: Wed, 08 Jan 2025 15:28:27 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@bors
Copy link
Contributor

bors commented Jan 8, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants