-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump crate version to 0.23.0 #444
Conversation
I'd like to see if we can get #435 in first. |
Is this a process thing, we only bump the version once we are ready to release? I just did this PR because we did a bunch of changes that needed it to be done at some stage before release. |
I think we should also get #406 in to decrease the frequency of breakages. #309 would be also great but it doesn't seem conclusion is near. I feel uneasy about the failing test in #435, so that'd be great to resolve as well. The remaining open PRs don't seem urgent to add here. (Yep, I went through all of them.) |
Yes, I like to use "bump Cargo.toml" version PRs as "release tracking issues" and do a release/tag immediately after merging. @Kixunil thanks for the summary! Regarding #406 I'm not sure if we want to have that PR ... I'm worried about doing the breakage at all and the benefit is not very large. It feels to me like the PR is stalled. |
Last change is 2 days ago, doesn't look stalled to me. IMO until 1.0 it's fine to do such breakage. (I would love to have 1.0 but that will take shitton of work.) |
I just rebased #406 the other day, I have no idea if it is definitely an improvement. I commented as such on the PR. |
Should be resolved now (assuming the cfg guard on fuzzing is ok). |
Can we have #448 in before release too please - add clippy to CI? |
Ok, only #448 is remaining. |
1 similar comment
Ok, only #448 is remaining. |
Woop woop, #448 is rebased and ready for review. As Odell would say, "let's f***ing go"! |
Nothing should block this now, right? |
@tcharding could you add a CHANGELOG update to this? Sorry for letting this PR drop.. |
Since I'm looking forward to this, I decided to help a bit and went through the commits to fill the changelog (ordered by what I believe to be most interesting to least interesting; non-sys crate changes only): Breaking changes
New features/APIs
Other improvements
|
Looks good! @tcharding if you could just copy/paste that comment into the changelog file I can ack it and merge/release. |
In preparation for release, write CHANGELOG release notes and bump the crate version to 0.23.0
f7d2aa5
to
c1d7358
Compare
Changes in force-push: rebased and added changelog. Re-wrote commit log and PR description to mirror this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c1d7358
Oops, I just noticed we didn't handle documentation well when merging tweak changes. Opened #453 |
Thanks! Fortunately I had to step away from my keyboard this morning and didn't haev time to merge this PR before your fix :) |
Oops, we need to also bump secp-sys because #331 added the |
#457 needs to be merged before |
Can we remove |
my bad. |
We just did an MSRV bump, this typically would require bumping our majorversion number but since we are pre 1.0 we bump the minor version
number.
In preparation for release, write CHANGELOG release notes and bump the crate version to 0.23.0
Thanks to Kixunil for sifting through the PRs to make the changelog list, I added links to the relevant PRs.