Support custom and whm socket integration type
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry! just realized that there's stuff still missing here like the client error handling code for WHM. |
|
Has this PR been completed now? If so, this pr can be merged. It would be even better if some test cases could be added. |
ItamarGronich
commented
Dec 24, 2024
ItamarGronich
commented
Dec 24, 2024
ItamarGronich
commented
Dec 24, 2024
|
@LingyuCoder yeah it's done now. |
ItamarGronich
changed the title
whm socket integration type
LingyuCoder
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
webpack-hot-middleware("whm"option inoverlay.socketIntegrationplugin option).This code is copied and modified from https://github.com/pmmmwh/react-refresh-webpack-plugin/blob/f770d3962c388da01eeda7079bff5f40c93992d2/sockets/WHMEventSource.js