Skip to content

Commit

Permalink
Fix additional inflation of toff during augmentation (fixes #69)
Browse files Browse the repository at this point in the history
The original code was for inplace covariance operations.
This caused an additional H*P_tofftoff*H^T to be added.
While this shouldn't hurt it just means our covariance is conservative after augmentation.
Removing doesn't seem to change simulation performance.
  • Loading branch information
rpng-guest committed Jul 6, 2020
1 parent 930fb92 commit 2295e7f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions ov_msckf/src/state/StateHelper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -574,8 +574,6 @@ void StateHelper::augment_clone(State *state, Eigen::Matrix<double, 3, 1> last_w
state->_Cov.block(0, state->_calib_dt_CAMtoIMU->id(), state->_Cov.rows(), 1) * dnc_dt.transpose();
state->_Cov.block(pose->id(), 0, 6, state->_Cov.rows()) +=
dnc_dt * state->_Cov.block(state->_calib_dt_CAMtoIMU->id(), 0, 1, state->_Cov.rows());
state->_Cov.block(pose->id(), pose->id(), 6, 6) +=
dnc_dt * state->_Cov(state->_calib_dt_CAMtoIMU->id(), state->_calib_dt_CAMtoIMU->id()) * dnc_dt.transpose();
}

}
Expand Down

0 comments on commit 2295e7f

Please sign in to comment.