Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/Dynamic_bridge] Add --fix-ros2-names CLI arg #443

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Feature/Dynamic_bridge] Add --fix-ros2-names CLI arg #443

wants to merge 1 commit into from

Conversation

ColinChargyPro
Copy link

This PR adds --fix-ros2-names CLI arg to automatically modify topic name which starts with a number (because it's invalid for ROS2 topic). ROS1 would allow names like "/lidar/bottom/1_2v" but ROS2 wouldn't:

terminate called after throwing an instance of 'rclcpp::exceptions::InvalidTopicNameError'
  what():  Invalid topic name: topic name token must not start with a number:
  '/lidar/bottom/1_2v'

This PR adds an underscore so the modified topic name would be valid in ROS2 ("" in the example)

@ColinChargyYona
[Feature/Dynamic_bridge] Add --fix-ros2-names CLI arg to automaticall…
0d731d8 
…y modify topic name which starts with a number (because it's invalid for ROS2 topic)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

@quarkytale quarkytale Awaiting requested review from quarkytale quarkytale is a code owner

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ColinChargyPro @ColinChargyYona