Add special case in parameter bridge for tf_static
#438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahiminfinite
requested review from
methylDragon,
quarkytale and
gbiggs
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a special case in the bidirectional parameter bridge for the
tf_statictopic.This modification was made as part of a requirement to get the
tf_statictopic from ROS 2 into ROS 1 as a latched topic.Making this PR in case this is of use to anyone else.
Suggestions for improvement are welcome
Known limitations:
The bridge connection from ROS 2 -> ROS 1 seems to be made only if the ROS 1 subscriber is running before the ROS 2 publisher.
However, for the ROS 1 - > ROS 2 direction, the connection is immediately made when the ROS 2 publisher is active even without a subscriber.