Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix github workflow for rolling. #86

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fix github workflow for rolling. #86

merged 2 commits into from
Jan 9, 2025

Conversation

fujitatomoya
Copy link
Contributor

closes #85

@christophebedard
Copy link
Member

The empy issue mentioned in #85 is now gone, but the GitHub job now fails just like the Rpr job.

@fujitatomoya
Copy link
Contributor Author

@christophebedard thanks for letting me know, i will take a look!

@fujitatomoya
Copy link
Contributor Author

i confirmed with local environment that ros2/rclcpp#2723 can fix the test failure happening in github workflow for rolling and rpr job.

@fujitatomoya
Copy link
Contributor Author

@christophebedard all green 👍

@fujitatomoya fujitatomoya merged commit c2523e1 into main Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rolling github workflow and Rpr job is failing.
2 participants
@fujitatomoya @christophebedard