Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black-pip key for debian and ubuntu #44281

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jackiescanlon
Copy link

Please add the following dependency to the rosdep database.

Package name:

black-pip

Package Upstream Source:

https://github.com/psf/black

Purpose of using this:

In apt the current version supported is 21.12b0 and the latest stable version available from black is 24.10.0 which includes bug fixes and feature updates that are desired. Also, 21.12b0 is not supported by the VS Code black extension.

Links to Distribution Packages

@jackiescanlon jackiescanlon requested a review from a team as a code owner January 24, 2025 20:58
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Jan 24, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid
  • ✅ Installers for new rosdep rules are valid

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black is packaged in the native packaging: https://packages.ubuntu.com/oracular/black

This rule will cause conflicts with users of the native packaging and so we can't add a pip rule for this. There are definitely new features in lots of packages but we have to keep coordinated with the broader distribution.

@jackiescanlon
Copy link
Author

Thanks @tfoote, I meant for this to only be an alternative to the native, not a replacement. Also, I see a precedent set elsewhere to allow the pip package to be added as an option if the native package is a major release behind: https://github.com/ros/rosdistro/pull/40564/files

Is this precedent no longer being followed?

@tfoote
Copy link
Member

tfoote commented Jan 27, 2025

We have a very clear policy in the review guidelines: https://github.com/ros/rosdistro/blob/master/REVIEW_GUIDELINES.md
Native packages are strongly preferred. If a native package exists for the key in question, then that should always be used over e.g. a pip key.

I will be submitting a revert for the linked PR at #44287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants