Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyubx2 #44166

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add pyubx2 #44166

wants to merge 4 commits into from

Conversation

ARK3r
Copy link
Contributor

@ARK3r ARK3r commented Jan 13, 2025

Please add the following dependency to the rosdep database.

Package name:

pyubx2

Package Upstream Source:

https://github.com/semuconsulting/pyubx2

Purpose of using this:

It's a "Python library for parsing and generating UBX GPS/GNSS protocol messages."

Links to Distribution Packages

https://pypi.org/project/pyubx2/

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@ARK3r ARK3r requested a review from a team as a code owner January 13, 2025 21:34
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Jan 13, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to rosdep:

  • ❌ There are problems with the names of new rosdep keys:
    • Keys which contain only pip rules should end in '-pip'
  • ✅ Platforms for new rosdep rules are valid
  • ✅ Installers for new rosdep rules are valid

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

rosdep/python.yaml Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid
  • ✅ Installers for new rosdep rules are valid

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

rosdep/python.yaml Outdated Show resolved Hide resolved
@clalancette clalancette added the changes requested Maintainers have asked for changes to the pull request label Jan 24, 2025
Co-authored-by: Chris Lalancette <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants