Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{rolling} WIP: Enable ROS Visualization tools #1144

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

robwoolley
Copy link
Collaborator

This fixes longstanding issues preventing Gazebo/Ignition and RViz2 from building with meta-ros.

This includes work to resolve Ogre-Next, PyQt5, and SIP.

This is a work-in-progress and is not yet completed. It is being shared for feedback and for others that wish to help contribute to fixing bugs or doing testing.

robwoolley and others added 13 commits May 6, 2024 09:06
Set the correct SPDX identifier for the package.

Install the license files into the correct directory if
LICENSE_CREATE_PACKAGE is set and we are building license packages.

Signed-off-by: Matthias Schoepfer <[email protected]>
Signed-off-by: Rob Woolley <[email protected]>
Updated to version 1.19.20240304 which is currently used on ROS 2 Rolling.

It no longer needs the patch which has disappeared upstream.

Signed-off-by: Matthias Schoepfer <[email protected]>
Signed-off-by: Rob Woolley <[email protected]>
These fixes are mostly setting LICENSE to BSD-3-Clause to conform with
SPDX short descriptions. Otherwise, "BSD" License will not be found
(since it is ambiguous).

Signed-off-by: Matthias Schoepfer <[email protected]>
Signed-off-by: Rob Woolley <[email protected]>
Introduce a yocto recipe for orocos-kdl, which basically makes any
appends to orocos-kdl-vendor obsolete.

Signed-off-by: Matthias Schoepfer <[email protected]>
These fixes are mostly setting LICENSE to BSD-3-Clause to conform with
SPDX short descriptions. Otherwise, "BSD" License will not be found
(since it is ambiguous).

Signed-off-by: Matthias Schoepfer <[email protected]>
Signed-off-by: Rob Woolley <[email protected]>
These fixes are mostly setting LICENSE to BSD-3-Clause to conform with
SPDX short descriptions. Otherwise, "BSD" License will not be found
(since it is ambiguous).

Signed-off-by: Matthias Schoepfer <[email protected]>
Signed-off-by: Rob Woolley <[email protected]>
This fixes longstanding issues preventing Gazebo/Ignition and RViz2 from
building with meta-ros.

This includes work to resolve Ogre-Next, PyQt5, and SIP.

This is a work-in-progress and is not yet completed.

Signed-off-by: Rob Woolley <[email protected]>
@robwoolley robwoolley changed the title WIP: Enable ROS Visualization tools {rolling} WIP: Enable ROS Visualization tools May 21, 2024
@robwoolley robwoolley self-assigned this May 21, 2024
@graceagrace
Copy link

Is this currently building/working? I see you have a separate PR open for ROS2 Humble + kirkstone support. How does this one differ? Can this be built against scarthgap?

@robwoolley
Copy link
Collaborator Author

Is this currently building/working? I see you have a separate PR open for ROS2 Humble + kirkstone support. How does this one differ? Can this be built against scarthgap?

Hi @graceagrace, they are both works-in-progress (WIP). I was sharing them with others in the hopes to get some help finishing it off. All the recipes were building, but some projects have optional dependencies that aren't satisfied yet. Notably, things like the ogre 3d engine which have support for different image libraries and plugins. I also didn't get to doing rigorous run-time testing however I did hear that some others were successful in running the GUIs.

The main difference between the two is that the older Yocto release uses sip v4 to generate the Qt Python bindings whereas the newer release uses sip v6 (see https://layers.openembedded.org/layerindex/recipe/332209/ ). This essentially doubled the effort. The newer Yocto release also uses gcc13 so at the time I was having to fix a lot of new C++ warnings in the compiler that hadn't been completely addressed yet by the upstream projects.

@graceagrace
Copy link

@robwoolley, thanks very much for the detailed reply. I am working on an image for developers that requires RVIZ and some Gazebo plugins. I plan to do a fair bit of runtime testing, so I'll certainly report back with any findings/additional patches required.

Is there a certain state you'd like to get this to before you would feel comfortable merging? Is it taking care of the optional deps, or something else?

@robwoolley
Copy link
Collaborator Author

Is there a certain state you'd like to get this to before you would feel comfortable merging? Is it taking care of the optional deps, or something else?

I would be happy with confirmation that someone built it and ran it. I think it is more important to get it in to avoid bit rot and allow others to pitch in to fix it. It should only be built by request so it shouldn't block anyone else.

You probably need this fix in order for it to work: robwoolley/meta-openembedded@3c4c1e8

I will try to find some time to push that to meta-openembedded soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants