-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows support #426
Add Windows support #426
Conversation
Thanks for your contributions. This is very helpful! Unfortunately I don't have a lot of experience with windows myself. But do you have an idea how I could include ci jobs testing on windows? |
I tried with official tooling in traversaro#1, but it is failing with the following message:
However, I do not myself have a lot of experience with official ROS Windows binaries. An alternative is to setup a job using robostack (https://robostack.github.io/index.html), in case you are interested you can find it in traversaro#2 . This second one is currently failing as |
(cherry picked from commit 913becd)
(cherry picked from commit 913becd)
(cherry picked from commit 913becd)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit 913becd) Co-authored-by: Silvio Traversaro <[email protected]>
(cherry picked from commit 913becd) Co-authored-by: Silvio Traversaro <[email protected]>
(cherry picked from commit 913becd) Co-authored-by: Silvio Traversaro <[email protected]>
The packages in this repo compile shared libraries, but does not expose any symbol on Windows, so no library is actually generated on Windows.
On Linux and macOS, everything compiles fine as by default all the symbols are visible. We can achieve exactly the same behavior in Windows by setting to
ON
theCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS
CMake variable, so this PR sets theCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS
variable toON
, to ensure that the compilation works fine on Windows.