-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grafana Integration #425
base: ros2
Are you sure you want to change the base?
Grafana Integration #425
Conversation
Build doesn't complete as it misses the dependency to cURL, @ct2034 could you help me with this? |
Co-authored-by: Christian Henkel <[email protected]>
Co-authored-by: Christian Henkel <[email protected]>
Yup that fixes it |
Thanks for your work. This looks very good. |
I've added unit tests for the conversion from The remaining code consists of a lightweight node that connects to an InfluxDB or Telegraf instance using basic |
Co-authored-by: Christian Henkel <[email protected]>
Co-authored-by: Christian Henkel <[email protected]>
Co-authored-by: Christian Henkel <[email protected]>
Co-authored-by: Christian Henkel <[email protected]>
diagnostic_remote_logging/include/diagnostic_remote_logging/influxdb.hpp
Outdated
Show resolved
Hide resolved
/********************************************************************* | ||
* Software License Agreement (BSD License) | ||
* | ||
* Copyright (c) 2009, Willow Garage, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean the year right? Or also the copyright holder? If so what should that be?
This is the first time i've done anything like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the copyright holder. And that is you or your company, depending on how you handle these things.
And please add your package to [.github/workflows/lint.yaml] and [.github/workflows/test.yaml] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also look at the linter feedback
|
||
This package provides the `influx` node, which listens to diagnostic messages and integrates with InfluxDB v2 for monitoring and visualization. Specifically, it subscribes to the [`diagnostic_msgs/DiagnosticArray`](https://index.ros.org/p/diagnostic_msgs) messages on the `/diagnostics_agg` topic and the [`diagnostic_msgs/DiagnosticStatus`](https://index.ros.org/p/diagnostic_msgs) messages on the `/diagnostics_toplevel_state` topic. The node processes these messages, sending their statistics and levels to an [`InfluxDB`](http://influxdb.com) database, enabling use with tools like [`Grafana`](https://grafana.com). | ||
|
||
As of now we only support InfluxDB v2, for support with older versions please use a proxy like [`Telegraf`](https://www.influxdata.com/time-series-platform/telegraf/). See section [Telegraf](## Using a Telegraf Proxy) for an example on how to setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. There is still something broken with the internal link. https://stackoverflow.com/questions/27981247/github-markdown-same-page-link
#### InfluxDB Configuration | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this section now empty? Please think about the structure of the readme again
/********************************************************************* | ||
* Software License Agreement (BSD License) | ||
* | ||
* Copyright (c) 2025, Willow Garage, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to add yourself and / or your company here instead of Willow Garage.
(Applies to all headers files with headers)
<version>4.3.1</version> | ||
<description>diagnostic_remote_logging</description> | ||
<maintainer email="[email protected]">Daan Wijffels</maintainer> | ||
<license>>BSD-3-Clause</license> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<license>>BSD-3-Clause</license> | |
<license>BSD-3-Clause</license> |
/********************************************************************* | ||
* Software License Agreement (BSD License) | ||
* | ||
* Copyright (c) 2009, Willow Garage, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the copyright holder. And that is you or your company, depending on how you handle these things.
Draft PR based on #401
Creating a new node that can export all diagnostics to telegraf or influxdb to be used with tools like grafana.