Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 fix(minor): ensure unique compiler name in cache service #2666

Merged
merged 2 commits into from
Dec 9, 2024
Merged

🩹 fix(minor): ensure unique compiler name in cache service #2666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8b08d8
🩹 fix(minor): ensure unique compiler name in cache service
kellymears Dec 9, 2024
8e1b9a4
🧪 test(none): update test assertion
kellymears Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sources/@roots/bud-cache/src/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ export default class Cache extends Service implements BudCache {
*/
public get name(): string {
const fallback = join(
this.app.label,
this.app.mode,
...Object.values(this.app.context._ ?? {}),
)
Expand Down
2 changes: 1 addition & 1 deletion sources/@roots/bud-cache/test/service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ describe(`@roots/bud-cache`, () => {
expect.arrayContaining([bud.path(`@modules`)]),
)
// @ts-ignore
expect(cache.configuration?.name).toEqual(`production`)
expect(cache.configuration?.name).toEqual(`@tests/project/production`)
// @ts-ignore
expect(cache.configuration?.profile).toEqual(false)
// @ts-ignore
Expand Down
12 changes: 6 additions & 6 deletions sources/@roots/wordpress-theme-json-webpack-plugin/src/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,9 +1176,9 @@ export interface RefComplete {
*/
export interface StylesElementsPropertiesComplete {
button?: {
[k: string]: unknown
} &
StylesElementsPseudoSelectorsProperties & StylesProperties
[k: string]: unknown
} & StylesElementsPseudoSelectorsProperties &
StylesProperties
caption?: StylesPropertiesComplete
cite?: StylesPropertiesComplete
h1?: StylesPropertiesComplete
Expand All @@ -1189,9 +1189,9 @@ export interface StylesElementsPropertiesComplete {
h6?: StylesPropertiesComplete
heading?: StylesPropertiesComplete
link?: {
[k: string]: unknown
} &
StylesElementsPseudoSelectorsProperties & StylesProperties
[k: string]: unknown
} & StylesElementsPseudoSelectorsProperties &
StylesProperties
}
export interface StylesElementsPseudoSelectorsProperties {
':active'?: StylesPropertiesComplete
Expand Down
Loading