Skip to content

Commit

Permalink
Add explicit dependencies for gems moving out of core
Browse files Browse the repository at this point in the history
Also unmark notification specs as pending
  • Loading branch information
flash-gordon committed Dec 25, 2024
1 parent f495aea commit 33ca12b
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
5 changes: 5 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,9 @@ group :test do
gem "ruby-oci8", platforms: :ruby if ENV["ROM_USE_ORACLE"]
gem "sequel_pg", require: false, platforms: :ruby
gem "sqlite3", "~> 1.4", platforms: :ruby

if RUBY_VERSION.start_with?("3.4")
gem "mutex_m"
gem "ostruct"
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

include_context "users"

xit "works" do
it "works" do
container.gateways[:default].use_logger(LOGGER)

sql = nil
Expand Down
8 changes: 2 additions & 6 deletions spec/integration/support/rails_log_subscriber_spec.rb
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
# frozen_string_literal: true

require "spec_helper"
require "active_support/log_subscriber/test_helper"

RSpec.describe "Rails log subscriber", :postgres, seeds: false do
before(:all) do
require "active_support/log_subscriber/test_helper"
rescue LoadError
end

before do
ROM::SQL.load_extensions(:active_support_notifications, :rails_log_subscriber)
end
Expand All @@ -29,7 +25,7 @@
container.gateways[:default].use_logger(logger)
end

xit "works" do
it "works" do
conn.run(test_query)

expect(logger.logged(:debug).last).to include(test_query)
Expand Down

0 comments on commit 33ca12b

Please sign in to comment.