BwDcompactExecFactory: Check GetApproximateSizes() return status

see: topling/todis#15
rockeet · Sep 13, 2023 · fc67066 · fc67066
1 parent 01f4c12
commit fc67066
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/bw_side_plugin.cc b/src/bw_side_plugin.cc
@@ -1232,8 +1232,13 @@ struct BwDcompactExecFactory : CompactionExecutorFactory {
     auto flags = DB::SizeApproximationFlags::INCLUDE_FILES
                | DB::SizeApproximationFlags::INCLUDE_MEMTABLES;
     uint64_t meta_size = 0;
+    uint64_t input_size = 0;
     Status s = db->GetApproximateSizes(&rng, 1, &meta_size, flags); // default cf
-    size_t input_size = 0;
+    if (!s.ok()) { // should not fail in real world
+      auto log = c->immutable_options()->info_log;
+      ROCKS_LOG_WARN(log, "GetApproximateSizes() failed, db: %s, cf: %s",
+                     db->GetName().c_str(), data_cfd->GetName().c_str());
+    }
     for (auto& lev : *c->inputs()) {
       for (auto& file : lev.files)
         input_size += file->fd.file_size;