Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import and tweak build parameters #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dlemos
Copy link

@dlemos dlemos commented Aug 5, 2024

I Followed the instructions to build https://github.com/rochus-keller/Cedar but I needed to change a few things in LeanQT to get it building on Ubuntu 24.10 using GCC 14.1.0

I'm not sure if any of this changes are really necessary, but if I don't change the C standard to gnu, stdio.h won't define asprintf in one place and vasprintf on another. And without the include I get errors that uintptr_t is undefined.

Unrelated suggestion: You should strongly advise on the README of project using LeanQT that people consider using LeanCreator, instead of using BUSY (directly?) to get the benefits of compiling in parallel.

@rochus-keller
Copy link
Owner

Thanks for the feedback. I will try to run a build on a recent Debian system and see if it works. Actually I would rather change the xcb/xkb code that is meets the C99 standard than depending on a proprietary GCC dialect. I will look at the source whether I can get rid of vasprintf/asprintf and replace it by a standard solution. So far there was no problem with it on all systems I tried. In atoms.c they did it right; will do the same thing in context.c.

@rochus-keller
Copy link
Owner

I just pushed a new commit with a fix, rplacing asprintf by sprintf, if you want to try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants