Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update to Bazel 7 #788

Merged
merged 4 commits into from
Dec 13, 2023
Merged

build: Update to Bazel 7 #788

merged 4 commits into from
Dec 13, 2023

Conversation

robinlinden
Copy link
Owner

No description provided.

With Bazel 7, trying to compile icu:common resulted in
`cl : Command line error D8004 : '/I' requires an argument`
@robinlinden robinlinden force-pushed the build-update-bazel branch 2 times, most recently from 11ca274 to ef13926 Compare December 13, 2023 00:23
This is required starting with Bazel 7.
--incompatible_enable_cc_toolchain_resolution is now flipped by default.
@robinlinden
Copy link
Owner Author

Bazel 7 switches gcov-8 and newer to use gcc's branch coverage. It seems a bit broken (how can something like std::stringstream ss; only have partial coverage?), but I think we should just bite the bullet for now and see if Clang does any better.

image

@robinlinden robinlinden marked this pull request as ready for review December 13, 2023 00:47
@robinlinden robinlinden merged commit 65d2d1c into master Dec 13, 2023
20 of 21 checks passed
@robinlinden robinlinden deleted the build-update-bazel branch December 13, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants