Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add macos build #787

Merged
merged 1 commit into from
Dec 12, 2023
Merged

ci: Add macos build #787

merged 1 commit into from
Dec 12, 2023

Conversation

Zer0-One
Copy link
Collaborator

@Zer0-One Zer0-One commented Dec 10, 2023 •
edited by robinlinden
Loading

Resolves #21

@Zer0-One Zer0-One force-pushed the master branch 30 times, most recently from c785c2b to fe41b92 Compare December 11, 2023 00:29
@Zer0-One Zer0-One force-pushed the master branch 8 times, most recently from 19505fe to 7cfe680 Compare December 11, 2023 03:38
@Zer0-One Zer0-One marked this pull request as ready for review December 11, 2023 04:09
@Zer0-One Zer0-One force-pushed the master branch 2 times, most recently from fce8fe2 to e646c7e Compare December 11, 2023 19:19
@Zer0-One
Copy link
Collaborator Author

It passes, but it's not building everything because of the targets that are only linux-compatible. e.g udev-zero dep for @sfml//:window on macos doesn't make any sense, but it gets the build working.

Do you wanna merge this and go from here? This will probably require code changes to get the whole thing building.

robinlinden
robinlinden requested changes Dec 11, 2023
View reviewed changes
Copy link
Owner

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! More than one person has looked at macOS-support before, so this is fantastic progress. :)

third_party/unifex.BUILD Outdated Show resolved Hide resolved
third_party/sfml.BUILD Outdated Show resolved Hide resolved
@Zer0-One Zer0-One force-pushed the master branch 8 times, most recently from ed3b450 to e0bd5f6 Compare December 12, 2023 20:16
@Zer0-One
Copy link
Collaborator Author

Now there's only 11 tests that are skipped.

@Zer0-One Zer0-One requested a review from robinlinden December 12, 2023 20:29
@Zer0-One Zer0-One force-pushed the master branch 3 times, most recently from 33a852a to 5d674a9 Compare December 12, 2023 21:27
robinlinden
robinlinden approved these changes Dec 12, 2023
View reviewed changes
Copy link
Owner

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super neat! That solves the oldest issue we have. :P

@Zer0-One Zer0-One merged commit 41396e3 into robinlinden:master Dec 12, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinlinden robinlinden robinlinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add macOS CI
2 participants
@Zer0-One @robinlinden