ci: Combine the asan and ubsan jobs #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running these two sanitizers together is fine, so let's do that to save ourselves a job. This means we're also updating the asan job to use LLVM 15 instead of 14, but that's fine since we still use LLVM 14 for our tsan tests.
We used to need this to get a correct code coverage report, but since we no longer merge using the buttons on the GitHub website, all our merges are fast-forward, and this should no longer be needed.
Zer0-One
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running these two sanitizers together is fine, so let's do that to save
ourselves a job. This means we're also updating the asan job to use LLVM
15 instead of 14, but that's fine since we still use LLVM 14 for our
tsan tests.