Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abomination #700

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add abomination #700

merged 1 commit into from
Nov 30, 2023

Conversation

Zer0-One
Copy link
Collaborator

brb, kms

@Zer0-One Zer0-One force-pushed the master branch 21 times, most recently from 99e36e2 to e16ba8b Compare September 20, 2023 23:26
@Zer0-One Zer0-One force-pushed the master branch 8 times, most recently from 993c620 to bcbdcce Compare October 3, 2023 18:02
@Zer0-One Zer0-One force-pushed the master branch 6 times, most recently from 4d3eb90 to 30c24d5 Compare November 24, 2023 19:33
robinlinden
robinlinden requested changes Nov 26, 2023
View reviewed changes
Copy link
Owner

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great work! Looks like having the uts46-data embedded was non-trivial. :(

Can you disable the things that depend on icu in the aarch64 cross-compilation CI job the same way I have for things that depend on @sfml//:window?

third_party/icu.BUILD Outdated Show resolved Hide resolved
third_party/icu.BUILD Outdated Show resolved Hide resolved
third_party/icu.BUILD Outdated Show resolved Hide resolved
third_party/icu.BUILD Outdated Show resolved Hide resolved
url/BUILD Outdated Show resolved Hide resolved
third_party/icu.BUILD Outdated Show resolved Hide resolved
@Zer0-One Zer0-One force-pushed the master branch 12 times, most recently from 56c4e91 to c2c3800 Compare November 27, 2023 22:10
@Zer0-One Zer0-One requested a review from robinlinden November 27, 2023 22:15
robinlinden
robinlinden requested changes Nov 28, 2023
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
url/BUILD Outdated Show resolved Hide resolved
url/url.cpp Show resolved Hide resolved
@Zer0-One Zer0-One force-pushed the master branch 2 times, most recently from ce90b88 to 149ea92 Compare November 29, 2023 03:00
@Zer0-One Zer0-One requested a review from robinlinden November 29, 2023 03:41
@Zer0-One
deps: Remove ICU data dep
2209f54 
Builds ICU data into a static library as part of the build instead of
fetching a binary data release archive, and links the library into the
URL lib.
@Zer0-One Zer0-One merged commit 2209f54 into robinlinden:master Nov 30, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinlinden robinlinden robinlinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zer0-One @robinlinden